Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service_lib and aar to the docs #2634

Merged
merged 5 commits into from
Jul 14, 2022
Merged

add service_lib and aar to the docs #2634

merged 5 commits into from
Jul 14, 2022

Conversation

mzakharo
Copy link
Contributor

  • Adding service_library and 'aar' generation to the documentation.
  • Removing absolute paths from service file declaration.
  • Adding mention of foreground and sticky options in services.

misl6
misl6 reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and a question.

Thank you for taking care about service_lib docs!

(And thank you for re-using a pygame-era paragraph 😂 which was still in the docs)

doc/source/buildoptions.rst Outdated Show resolved Hide resolved
doc/source/quickstart.rst Outdated Show resolved Hide resolved
doc/source/services.rst Outdated Show resolved Hide resolved
@mzakharo mzakharo requested a review from misl6 July 14, 2022 19:14
misl6
misl6 requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion on a minor typo, but looks good!

doc/source/services.rst Outdated Show resolved Hide resolved
@mzakharo @misl6
Update doc/source/services.rst
128528b 
Co-authored-by: Mirko Galimberti <[email protected]>
@mzakharo mzakharo requested a review from misl6 July 14, 2022 20:17
misl6
misl6 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit cae8a85 into kivy:develop Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzakharo @misl6